EA-5554: Bug fix for responders

jtl-software · Nov 30, 2023 · b87b3d1 · b87b3d1
1 parent 522f005
commit b87b3d1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Alert/CreateAlertRequest.php b/src/Alert/CreateAlertRequest.php
@@ -59,7 +59,7 @@ public function getBody(): array
         }
 
         foreach ($this->alert->getResponders() as $responder) {
-            $body['responders'] = [
+            $body['responders'][] = [
                 'id' => $responder->getId(),
                 'type' => $responder->getType()
             ];

diff --git a/tests/Alert/CreateAlertRequestTest.php b/tests/Alert/CreateAlertRequestTest.php
@@ -38,12 +38,14 @@ public function testCanAppendResponder(): void
     {
         $alert = $this->createMock(Alert::class);
         $alert->expects($this->atLeastOnce())->method('getResponders')->willReturn([
-            $this->createMock(Responder::class),
-            $this->createMock(Responder::class)
+            new Responder('foo', Responder::team),
+            new Responder('bar', Responder::user),
         ]);
         $request = new CreateAlertRequest($alert);
 
         $this->assertArrayHasKey('responders', $request->getBody());
+        $this->assertEquals(['id' => 'foo', 'type' => 'team'], $request->getBody()['responders'][0]);
+        $this->assertEquals(['id' => 'bar', 'type' => 'user'], $request->getBody()['responders'][1]);
     }
 
     public function testCanAppendTags(): void