Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revised Build VS2022 version Agriculture card played first is not displayed properly on tableau #2

Open
frankk74 opened this issue Jun 3, 2022 · 14 comments
Open

Revised Build VS2022 version Agriculture card played first is not displayed properly on tableau #2

frankk74 opened this issue Jun 3, 2022 · 14 comments
Assignees
@jsparkes
Labels
bug Something isn't working

Comments

@frankk74
Copy link
Collaborator

frankk74 commented Jun 3, 2022

There is a white square with error text that isn't readable. It might be related to color id warning/error messages?

The card display in top left have the text with matching card displayed correctly.
@frankk74
Copy link
Collaborator Author

frankk74 commented Jun 7, 2022

Capture

As we were discussing you changed font size and that didn't fix it, you talked about Transparent...

The image above showing old and new shows it is a Transparency issue in multiple place: Top Left Card Display, Meld Board in the middle and player hand.

This might be a subtle interaction with forms and visual studio?

@frankk74 frankk74 changed the title Revised version missing text on cards that are on the board Revised Build VS2022 version Cards being rendered incorrectly Jun 7, 2022
@frankk74
Copy link
Collaborator Author

frankk74 commented Jun 7, 2022

Another possibly related issue is mouse events are not working? When moving over a card in your hand or on your meld area/tableau it should show the details of the card in the top left but the update never happens.

A stackoverflow question mentions the mouse events and the background color (not sure if related to this or not):

https://stackoverflow.com/questions/50832670/vb-net-mouseenter-and-mouseleave-event-not-working

@jsparkes
Copy link
Owner

jsparkes commented Jun 7, 2022

I think the mouse enter events are no longer being caught. If you can find out the name of that event in .NET I can fix it.

@frankk74
Copy link
Collaborator Author

frankk74 commented Jun 8, 2022

Oh it might not be transparency? Could it be coloring of the textbox?

@jsparkes
Copy link
Owner

jsparkes commented Jun 8, 2022 via email

@frankk74
Copy link
Collaborator Author

frankk74 commented Jun 9, 2022

Yes the tableau images might have that problem but I thought you tried changing the font sizes and that didn’t fix anything? In image above both Card Images in the top left of the form/window/ui show the text fitting inside but the text window isn’t transparent….? I think that might VS designer item? I have resized the UI and elements and icons to the build in 2 places. Also I updated the title image I’ll be doing a PR shortly with these updates…

@jsparkes
Copy link
Owner

jsparkes commented Jun 9, 2022

I fixed the white squares. The label for the title was two wide, I changed it from 137 to 105 and the overwiting no longer occurs. I also changed the title font size from 12 to 10 to stop truncating some longer titles.

@frankk74

This comment was marked as resolved.

Sign in to view
@frankk74
Copy link
Collaborator Author

frankk74 commented Jun 27, 2022 •
edited
Loading

By avoiding the use of transparency (as it is now using the main form hence the grey) and changing the text Color to match the background images seems to have fixed most of the issues.

But either this change: efa3ed2

or this one c9f7473

seems to have some artifacts for the yellow (wrong yellow and image isn’t overlaid?) and purple tableau card’s text is grey and for the AI player’s purple display (its grey)

see image

image

@frankk74

This comment was marked as outdated.

Sign in to view
@frankk74
Copy link
Collaborator Author

frankk74 commented Jun 28, 2022 •
edited
Loading

Purple issues were my typos.... fixed in code 117 for rGb value not 171 and fixed in in VS designer (not sure if that is required?) correction was just pushed....

[Yellow card is still weird after 2nd card is melded ontop the card looks right. So the first meld is not working right just for tableau card 0] Might be working

@jsparkes
Copy link
Owner

jsparkes commented Jun 29, 2022 via email

@frankk74
Copy link
Collaborator Author

frankk74 commented Jun 29, 2022 •
edited
Loading

Yellow problem only occurs when agriculture is first card in yellow stack it’s really weird set of conditions

@frankk74 frankk74 added the bug Something isn't working label Jun 30, 2022
@jsparkes
Copy link
Owner

jsparkes commented Jun 30, 2022 via email

@frankk74 frankk74 changed the title Revised Build VS2022 version Cards being rendered incorrectly Revised Build VS2022 version Agriculture card played first is not displayed properly on tableau Jul 6, 2022
@frankk74 frankk74 mentioned this issue Jul 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jsparkes jsparkes

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jsparkes @frankk74