Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commit hash of each changelog content cannot be converted into link #776

Open
abjutus opened this issue Feb 1, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@abjutus
Copy link

abjutus commented Feb 1, 2024

Description

No matter if I customize the options or not, the link of commit hash could not be generated correctly.

https://github.com/abjutus/portfolio/commit/713e3790162b736c3f5180023143bf8440285a03

image

Configurations

Even I use the string type preset, and run command nx run portfolio:version, it did not generate changelog content as expected.

{
  ...,
  "version": {
    "executor": "@jscutlery/semver:version",
    "options": {
      "baseBranch": "main",
      "preset": "conventionalcommits",
      "commitMessageFormat": "release: bump version to {version} [skip ci]"
    }
  }
}
@edbzn
Copy link
Member

edbzn commented Feb 1, 2024

Hi @abjutus, you edited the generated file in the link, right? If you check the changelog here links of commit sha are correct, no need to customize it to work with GitHub.

@edbzn edbzn added the bug Something isn't working label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants