Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 : eliminate circular dependencies #1258

Open
z3dev opened this issue Jun 18, 2023 · 1 comment · Fixed by #1267
Open

V3 : eliminate circular dependencies #1258

z3dev opened this issue Jun 18, 2023 · 1 comment · Fixed by #1267
Labels

Comments

@z3dev
Copy link
Member

z3dev commented Jun 18, 2023

Expected Behavior

Modules / functions reference(import) specific functionality instead of using indexes.

Actual Behavior

When running the build for modeling, the following error is published by rollup.

(!) Circular dependency
src/primitives/index.js -> src/primitives/torus.js -> src/operations/extrusions/index.js -> src/operations/extrusions/extrudeRectangular.js -> src/operations/extrusions/extrudeRectangularPath2.js -> src/operations/expansions/index.js -> src/operations/expansions/expand.js -> src/operations/expansions/expandGeom3.js -> src/operations/expansions/expandShell.js -> src/primitives/index.js

Steps to Reproduce the Problem

  1. cd to modeling directory
  2. pnpm run build

Specifications

  • Version: V3
  • Platform: All
  • Environment: All
@z3dev z3dev added the V3 label Jun 18, 2023
@z3dev
Copy link
Member Author

z3dev commented Jun 19, 2023

In general, imports of named functions should be importing from a file, not from an index. This eliminates extra imports, and circular dependencies.

In general, import directly from files if possible. Don't use indexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant