You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At map1 if the player died and got whip. The whip will stay with the player after the level
restart. The problem is when the player got another whip, the player image got removed.
What i found:
in sprite.js line 113 :
+++ document.getElementById("debug").innerHTML = current_idx + ' ' + this.composition;
in index.html line 30:
+++ <div id="debug"></div>
Player has no whip and is now collide with whip:
Expected:
1 player, whip
actual:
1 player, whip
Player has whip and collide with whip:
Expected:
1 player, whip
actual:
0 whip, whip
And the player image got removed
The text was updated successfully, but these errors were encountered:
Thanks! I didn't even check for that situation! It's a result of hacking in Jason's sprite composition system without enough testing, but your solution looks good! If you want to submit a pull request with that change, I'd be happy to add it.
There is a similar problem with the jetpack (just that if a player collects it then dies, they still have it). At some point I should probably code something that remove items from that level on death, but I've moved on from this project (for now). One day!
At map1 if the player died and got whip. The whip will stay with the player after the level
restart. The problem is when the player got another whip, the player image got removed.
What i found:
in sprite.js line 113 :
+++ document.getElementById("debug").innerHTML = current_idx + ' ' + this.composition;
in index.html line 30:
+++ <div id="debug"></div>
Player has no whip and is now collide with whip:
Expected:
1 player, whip
actual:
1 player, whip
Player has whip and collide with whip:
Expected:
1 player, whip
actual:
0 whip, whip
And the player image got removed
The text was updated successfully, but these errors were encountered: