Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date Picker - Experimental time #4423

Open
4 of 11 tasks
akawanishi opened this issue Nov 19, 2024 · 1 comment
Open
4 of 11 tasks

Date Picker - Experimental time #4423

akawanishi opened this issue Nov 19, 2024 · 1 comment
Labels
status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working

Comments

@akawanishi
Copy link

Latest version

  • I have tested the latest version

Description

Dark mode for time in experimental time Date picker has different color treatment than the date input, is this expected?
Also, the AM/PM label is being cropped.

Steps to reproduce

check out example in Storybook
https://storybook.saltdesignsystem.com/?path=/story/lab-date-picker--with-experimental-time&globals=mode:dark;density:touch;themeNext:enable;corner:rounded

Expected behavior

No response

Package name(s)

Lab (@salt-ds/lab)

Package version(s)

latest

Browser

  • Chrome
  • Safari
  • Firefox
  • Microsoft Edge

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@akawanishi akawanishi added status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working labels Nov 19, 2024
@origami-z
Copy link
Contributor

Features not documented on the official website is not fully ready.

DatePickerTimeInput hasn't gone through proper design cycles, it is there to help validate the feasibility to provide custom controls to the main Date Picker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: bug 🪲 Something isn't working
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

No branches or pull requests
2 participants
@origami-z @akawanishi