Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart theme #3323

Open
origami-z opened this issue Apr 26, 2024 · 18 comments
Open

Chart theme #3323

origami-z opened this issue Apr 26, 2024 · 18 comments

Comments

@origami-z
Copy link
Contributor

origami-z commented Apr 26, 2024

Depends on categorical palette (#2523) to be in place first. Look into possible solutions like ag grid theme, so that our users are less dependent on us to keep version up to date.

@mark-tate
Copy link
Contributor

Espresso Goal: Kickoff required in Frappe, focus this sprint is on the Charts colors

@mark-tate
Copy link
Contributor

Chart support has started : initially through ticket #3937.
We will be continuing to prioritise this effort during Q3.
If you are a stakeholder who needs Charting and can provide use-cases and or issues with the existing inner-sourced UITK solution, please contact the Salt Product team.

@mark-tate
Copy link
Contributor

Focus is on Categorical color reorder to support chart theme in Q4

@mark-tate
Copy link
Contributor

On hold until v12 released
https://www.highcharts.com/blog/changelog/
Aiming to complete effort by end of Q4 assuming capacity and outcome of v12 review

@mark-tate
Copy link
Contributor

Galao Goal: Meeting to identify tasks and dependencies to create more concrete tasks for Latte @dplsek

@mark-tate
Copy link
Contributor

May not be in a position to start in Latte ?
Review at EOS .. HighCharts 12 ?

@origami-z
Copy link
Contributor Author

Looking at @dplsek and my capacity, we will likely start early Nov. @bhoppers2008 mentioned we should look at how much we can lift and shift from UITK chart

@mark-tate
Copy link
Contributor

Latte Goal: Meeting to identify initial tasks and dependencies to create more concrete tasks for Latte @dplsek

@dplsek
Copy link

dplsek commented Oct 25, 2024

Initial kick-off meeting complete.

Sample charts shared by Shannon

@mark-tate
Copy link
Contributor

Lungo Goal: Dev work waiting for High Charts 12 release.
Design work needs prioritisation and tickets added @bhoppers2008 (4 sprints remaining)

@amritadesmet
Copy link
Contributor

amritadesmet commented Nov 4, 2024

Latte: Amrita + Darrin meeting with UITK chart designer on Nov 5th to discuss relevant data viz changes, missing info etc

@amritadesmet
Copy link
Contributor

amritadesmet commented Nov 6, 2024

Update: Met with Yin, chart designer

Capital Connect Charts:

  • Focus on using harmonious colors rather than distinct ramp.
  • Palette was created by an external agency.
  • A limited set of 12 colors is used in Capital Connect, with a recent shift towards JPMC masterbrand colors.
  • Use of colors is flexible, provided they do not clash with the Teal CTA.
  • To avoid color clashes between charts, the order of colors may vary, inspired by the Carbon design system.
  • Users are encouraged to select distinct pre-set color options for each chart, meaning that colors will be represented differently in various charts.

Dark Mode Support:

  • Capital Connect doesn't currently support dark mode.
  • No active development due to uncertainty about migrating to Salt.

@mark-tate
Copy link
Contributor

Macc Goal: no work planned in Macc
Risk of slipping to Q1 as HighCharts 12, not yet released

@origami-z
Copy link
Contributor Author

MTK response:
Like Salt, MTK doesn't wrap HighCharts, just provide examples to integrate with rest of system.

Need the theme with the following features:

  • Categorical colors
  • Line styles – for line charts
  • Pattern fill styles – for bar/column/area/etc. charts
  • Data point symbols

https://go/mtk-storybook-beta/?path=/story/charts-highchart--line-chart

@origami-z
Copy link
Contributor Author

Vida has a slightly different charting ramp, will need to see what we can do with them v.s. categorical palette

@origami-z
Copy link
Contributor Author

+1 stakeholder wanting this I729079

@mark-tate
Copy link
Contributor

Mocha: no planned work, stretch goal if we have capacity.

Blocked until we have High Charts 12 on dev side

By EOY, we hope to look spec some design examples

@bhoppers2008
Copy link

(ZC) Highchart released v12 last week. Can be worked on now (with capacity). No other progress planned this sprint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

6 participants