Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested StackLayouts with separators share tokens #2698

Closed
3 of 10 tasks
libertymayc opened this issue Nov 8, 2023 · 2 comments
Closed
3 of 10 tasks

Nested StackLayouts with separators share tokens #2698

libertymayc opened this issue Nov 8, 2023 · 2 comments

Comments

@libertymayc
Copy link
Contributor

libertymayc commented Nov 8, 2023

Package name(s)

Core (@salt-ds/core)

Package version(s)

most recent

Description

When you nest a Stack Layout (of row direction - potentially will happen with both directions) within another, and set the inner gap to be different, the position of the first separator picks up the --stackLayout-gap-multiplier token from the nested Layout

At the same time, can clean up some tokens/code throughout of seEerator spelling, which differ from the spelling of 'sepArators' prop

Steps to reproduce

<StackLayout separators>
    <StackLayout gap={7} separators direction={'row'}>
        <div>hello</div>
        <div>hello</div>
    </StackLayout>
    <div>something else</div>
</StackLayout>

notice the outer stack picks up the gap of 7 coming from nested layout

Expected behavior

tokens should respect their own gap

Operating system

  • macOS
  • Windows
  • Linux
  • iOS
  • Android

Browser

  • Chrome
  • Safari
  • Firefox
  • Edge

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@libertymayc libertymayc added type: bug 🪲 Something isn't working status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Nov 8, 2023
@origami-z origami-z moved this from Green to Planned in Salt - Components, Patterns and Theming Nov 15, 2023
@origami-z origami-z added priority: medium 😠 and removed status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. labels Nov 15, 2023
@mark-tate
Copy link
Contributor

@libertymayc is this still an issue ?

@Fercas123
Copy link
Contributor

I had a look and this seems to be resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants