Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

layout is lost with latest jquery 3.6.0 #138

Open
edjekadetje opened this issue Mar 4, 2021 · 3 comments · May be fixed by #142
Open

layout is lost with latest jquery 3.6.0 #138

edjekadetje opened this issue Mar 4, 2021 · 3 comments · May be fixed by #142

Comments

@edjekadetje
Copy link

The text and title dont show anymore with latest jquery version
@cybenauts
Copy link

Copy

@cybenauts
Copy link

cybenauts commented Mar 7, 2022 •
edited
Loading

If you are using additional styles for eg. metro or bootstrap. Avoid self closing HTML tags
$.notify.addStyle("metro", { html: "<div>" + "<div class='image' data-notify-html='image'></div>" + "<div class='text-wrapper'>" + "<div class='title' data-notify-html='title'></div>" + "<div class='text' data-notify-html='text'></div>" + "</div>" + "</div>", classes: {........

Use
<div>...</div>
instead of
<div ... />

@edjekadetje
Copy link
Author

I solved it by editing the notify-metro.js, that script has closing tags. Maybe update the lib with this

Mark-Hetherington added a commit to Mark-Hetherington/notifyjs that referenced this issue Aug 4, 2022
@Mark-Hetherington
Avoid self closing tag
aa29d11 
This makes it compatible with newer Jquery. Resolves jpillora#138
@Mark-Hetherington Mark-Hetherington linked a pull request Aug 4, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid self closing tag Mark-Hetherington/notifyjs
2 participants
@cybenauts @edjekadetje