-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS improvements #94
base: master
Are you sure you want to change the base?
iOS improvements #94
Conversation
Handle all control states, not just some Add Switch element Ensnazz demo Use isEqualToAttributedString: when needed Add contentInset & scrollIndicatorInsets properties to table view
Hmm, so if I apply the following patch: diff --git a/Few-iOS/TableView.swift b/Few-iOS/TableView.swift
index de5c1bf..eaf8269 100644
--- a/Few-iOS/TableView.swift
+++ b/Few-iOS/TableView.swift
@@ -322,14 +322,10 @@ public class TableView: Element {
tableView.scrollIndicatorInsets = scrollIndicatorInsets
if let header = header {
handler.headerView.updateWithElement(header)
- let layout = header.assembleLayoutNode().layout(maxWidth: tableView.frame.width)
- layout.apply(handler.headerView)
tableView.tableHeaderView = handler.headerView
}
if let footer = footer {
handler.footerView.updateWithElement(footer)
- let layout = footer.assembleLayoutNode().layout(maxWidth: tableView.frame.width)
- layout.apply(handler.footerView)
tableView.tableFooterView = handler.footerView
}
return tableView It gets rid of the table header jank. But the section header still shifts. I'm not sure what's going on there. |
The new report. Don't understand. Is the front end development. I am learning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UQAW2tMwlGyPUM4Jy6yJocPQPdk5mOddZFOyKaE4Pp8DDHTX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UQAW2tMwlGyPUM4Jy6yJocPQPdk5mOddZFOyKaE4Pp8DDHTX
@joshaber This one's a biggie, sorry. I wanted to get the demo working in decent shape before PR. What we've got is
Switch
element forUISwitch
Button
lay itself out correctlyButton
respect more control statesisEqualToAttributedString:
when possiblecontentInset
andscrollIndicatorInsets
toTableView
The changes seemed to have exposed layout bugs in other chunks of the framework, so we'll tackle those later. The layout of elements in the table header is wonky when you switch between demo screens and on first appearance. Curious if you have ideas about the causes there.