Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe typing of PrintdCallbackArgs.launchPrint #26

Open
jraoult opened this issue Oct 3, 2024 · 1 comment
Open

Unsafe typing of PrintdCallbackArgs.launchPrint #26

jraoult opened this issue Oct 3, 2024 · 1 comment

Comments

@jraoult
Copy link

jraoult commented Oct 3, 2024

Using Function to type a function is not ideal in typescript and is now considered unsafe by typescript-eslint (see the rationale here: typescript-eslint/typescript-eslint#9108) so that calling launchPrint() now fails in my lint stage.

I checked the source code, and it turns out it should be pretty easy to fix by declaring launchPrint: () => void since it is not supposed to return anything.

I am happy to create a PR if you need me to.

@joseluisq
Copy link
Owner

Sure, feel free to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants