Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we change standard from <br /> to <br> ? #267

Open
infograf768 opened this issue Aug 28, 2020 · 4 comments
Open

Can we change standard from <br /> to <br> ? #267

infograf768 opened this issue Aug 28, 2020 · 4 comments

Comments

@infograf768
Copy link
Member

https://github.com/joomla/coding-standards/blob/master/manual/html.md#adding-line-breaks

afaik, it looks not necessary to use <br /> as this is rather for xhtml.
<br> should be OK.

Ref:
https://www.tutorialspoint.com/What-is-the-correct-way-of-using-br-br-or-br-in-HTML

So the question is:

  1. Shall we keep <br /> as a standard for 3.x
  2. Shall we change the standard to <br> generally speaking or specially for J4 as we have
    9 occurences of <br />
    216 occurences of <br>

@mbabker @wilsonge @HLeithner

@anibalsanchez
Copy link

The latest HTML5 spec defines the br element as <br> https://www.w3.org/TR/html52/textlevel-semantics.html#the-br-element

So, the issue is more like the usage of <br />, that should be removed to avoid further confusion.

@anibalsanchez
Copy link

Of course, <br /> has to be removed from the coding standard as an option.

@wilsonge
Copy link
Contributor

J3 will stand as xhtml compatible br (as we’ve had xhtml templates support there from early j3). From j4 should need be the html 5 br without the self closing tag

@infograf768
Copy link
Member Author

OK, used <br /> in staging as it looks like we have to keep that.
Can someone modify the standard for J4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants