Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark misstake? #30

Open
jimmywarting opened this issue Aug 7, 2021 · 1 comment · May be fixed by #33
Open

benchmark misstake? #30

jimmywarting opened this issue Aug 7, 2021 · 1 comment · May be fixed by #33

Comments

@jimmywarting
Copy link

jimmywarting commented Aug 7, 2021 •
edited
Loading

is-number/benchmark/index.js

Line 83 in 98e8ff1

function isNumber61(val) {

Think val should be named num

Same thing with

is-number/benchmark/index.js

Line 57 in 98e8ff1

function isNumberParseFloat(n) {

@jonschlinkert
Copy link
Owner

yikes, good catch. A PR would be welcome, thanks for creating the issue

@Cyklan Cyklan linked a pull request Dec 27, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed wrong parameter names in benchmark
2 participants
@jonschlinkert @jimmywarting