Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show some Cppcheck messages on file-level #60

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Dec 23, 2020

image

Workarounds for the messages in question will be outlined in an upcoming PR which fleshes out the Known Issues section in the documentation.

These should probably be shown as warnings but I chose to keep the severity provided by Cppcheck intact.

@firewave firewave force-pushed the global branch 2 times, most recently from 53d68b7 to 9365b78 Compare December 23, 2020 15:19
@firewave firewave marked this pull request as draft December 24, 2020 10:44
@firewave
Copy link
Collaborator Author

This is a bit too much for 1.6.0 - we need to get the --xml stuff and the other fixes out first.

@firewave
Copy link
Collaborator Author

firewave commented Jan 7, 2021

I have a patch for Cppcheck ready to make missingInclude available with the normal analysis. I will add handling for it with a version check.

I will also hide all these additions in this PR behind the VERBOSE flag for now so it can be merged. I will make that flag available via the configuration later on.

@firewave
Copy link
Collaborator Author

firewave commented Mar 12, 2022

I re-wrote the Known Issue section since it applies to some of these global warnings. I also enabled it in the regular build since these message might indicate reasons for false positive/negatives. The amount of messages will be reduced when we fix some of the known issues.

I will be dogfooding this for a few days before I move it out of the draft status.

Please also have a look at the documentation changes if they are understandable.

@firewave
Copy link
Collaborator Author

Seems to be working as expected. Need to go over the documentation changes one more time and then it should be good to go.

@firewave
Copy link
Collaborator Author

Cppcheck will now show all the individual missingInclude and missingIncludeSystem messages so I need to test this a bit more first. Probably will see if there are any more minor fixes I could put into 1.6.3.

@firewave firewave mentioned this pull request Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant