New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to split `AppData::m_appData` into platform and renderer depended #63

Open

ChemistAion opened this issue Jun 24, 2023 · 0 comments

ChemistAion commented Jun 24, 2023 •

edited

Loading

Such as: https://github.com/ocornut/imgui/blob/6b2e03c5b1bc4f99dbd86d10e5fd12af9e3fe1c2/imgui.h#L2005-L2009

Premise for that:

all platform stuff, e.g: im3d_impl_win32 internals goes to (as-is): AppData::m_appData
all renderer depended stuff, e.g.: im3d_impl_dx12 goes to: AppData::m_rendererData <-- TODO

Now, we have a nice AppData for different renderers.... 😇

The text was updated successfully, but these errors were encountered:

ChemistAion added a commit to ChemistAion/im3d that referenced this issue


          Split AppData::m_appData into platform (as-is: m_appData) and rendere…

443a5a3

…r depended (m_rendererData introduced)

Premises: https://github.com/ocornut/imgui/blob/6b2e03c5b1bc4f99dbd86d10e5fd12af9e3fe1c2/imgui.h#L2005-L2009

This pull-req addresses: john-chapman#63

ChemistAion added a commit to ChemistAion/im3d that referenced this issue


          Split AppData::m_appData into platform (as-is: m_appData) and rendere…

0f069b0

…r depended (m_rendererData <-- new one)

Premises: https://github.com/ocornut/imgui/blob/6b2e03c5b1bc4f99dbd86d10e5fd12af9e3fe1c2/imgui.h#L2005-L2009

This pull-req addresses: john-chapman#63

ChemistAion mentioned this issue

Split AppData::m_appData for renderer data #65

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment