Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests take a long time to run #5

Open
ianhinder opened this issue May 6, 2022 · 1 comment
Open

Tests take a long time to run #5

ianhinder opened this issue May 6, 2022 · 1 comment

Comments

@ianhinder
Copy link
Contributor

On my machine, the LIFE test suite takes about 6 minutes to run, making it less likely that people will run them. I notice that the test cases run a lot of timesteps. If the purpose is to test for regressions, then probably only a few timesteps are needed. The resolution also doesn't need to be very high.

Would it make sense to reduce the number of timesteps, and potentially also the resolution of each test?
@ianhinder
Copy link
Contributor Author

I've just realised that the tests are the same as the examples. In that case, the examples need to be physically realistic and interesting. Maybe the test system could change nSteps to 10 when copying params.h? Are there any cases where regressions could be introduced that are not picked up in the first 10 timesteps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ianhinder