Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set extensionKind to workspace & Use pylsp directly as the language server #121

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

set extensionKind to workspace & Use pylsp directly as the language server #121

wants to merge 2 commits into from

Commits on Oct 28, 2024

  1. chore(extensionKind): set extensionKind to workspace 

    Setting the extensionKind to workspace allows the extension to be
activated in the context of a workspace. This is useful for users
who uses the extension connecting the VS Code UI to a remote VS Code
server. This way the pylsp used will be always the one installed from
the workspace environment.

Also bump the vscode packages.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
    @microhobby
    microhobby committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    1758467 View commit details
    Browse the repository at this point in the history

  2. chore(pylsp): Use pylsp directly as the language server 

    Previously, the extension was using a TCP connection, but was not
clear how the pylsp was being started. Also the pylsp.executable
was being set, but it's value was not being used.

This patch changes the way the language server is started, now
using the pylsp executable directly, and also uses the pylsp.executable
value to set the command to be executed.

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
    @microhobby
    microhobby committed Oct 28, 2024
    Configuration menu
    Copy the full SHA
    86e9848 View commit details
    Browse the repository at this point in the history