set extensionKind to workspace & Use pylsp directly as the language server #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the extensionKind to workspace allows the extension to be activated in the context of a workspace. This is useful for users who uses the extension connecting the VS Code UI to a remote VS Code server. This way the pylsp used will be always the one installed from the workspace environment. Also bump the vscode packages. Signed-off-by: Matheus Castello <matheus@castello.eng.br>
Previously, the extension was using a TCP connection, but was not clear how the pylsp was being started. Also the pylsp.executable was being set, but it's value was not being used. This patch changes the way the language server is started, now using the pylsp executable directly, and also uses the pylsp.executable value to set the command to be executed. Signed-off-by: Matheus Castello <matheus@castello.eng.br>
jnoortheen
reviewed
Oct 28, 2024
| "publisher": "jnoortheen", | ||
| "icon": "images/icon.png", | ||
| "license": "MIT", | ||
| "engines": { | ||
| "vscode": ">=1.75.0" | ||
| }, | ||
| "extensionKind": [ | ||
| "workspace" | ||
| ], |
There was a problem hiding this comment.
what is the implication if this? does this work when we edit a single file ?
There was a problem hiding this comment.
yes, this works even though the user open a single file without a workspace opened. The extensionKind is only to set the https://code.visualstudio.com/api/advanced-topics/extension-host#preferred-extension-location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was the way to make it work for me.
I use it in a Windows environment but in WSL 2.
This probably fixes #90
Was not clear to me if the
pylspneed to be run apart from the extension, in my environment it was blocked in theclient.startforever, but using it directly worked.