Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way for players to start a game now #768

Open
jkomoros opened this issue Jul 28, 2020 · 0 comments
Open

A way for players to start a game now #768

jkomoros opened this issue Jul 28, 2020 · 0 comments

Comments

@jkomoros
Copy link
Owner

Originally captured in #755.

moves.WaitForEnoughPlayers currently fires as soon as MinNumPlayers are active and seated. But in some cases you want to allow the players to choose to wait for more players or get going.

A way for special players to say "It's OK to start". Maybe have it just be that WaitForEnoughPlayers checks, if Admin then it checks at least TargetCount, but if it's a player it lets them propose it before then? Or I guess you always need at least TargetCount to be legal to go, so maybe WaitForEnoughPlayers has a AllowPlayer() bool and if true then it only is legal if a player does it. (And update the logic of wilSeatPlayer in Legal, which currently just returns nil immediately)

Maybe only the very first (index 0) player can say it's OK to start. Or maybe all players can.

You also want a way for a "Start round" button to light up only when it's legal to fire that in the client. Ideally that button literally wouldn't even show except when it might be valid. (And only show enabled for players who are allowed to hit it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant