coderabbit changes

jinek · Nov 25, 2024 · e83a7cb · e83a7cb
1 parent dcb3c1a
commit e83a7cb
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 7 deletions.
diff --git a/src/Consolonia.Core/Controls/DialogWindow.cs b/src/Consolonia.Core/Controls/DialogWindow.cs
@@ -166,7 +166,7 @@ public virtual void CloseDialog(object result = null)
         public async Task ShowDialogAsync(Control parent)
         {
             if (_taskCompletionSource != null)
-                throw new NotImplementedException();
+                throw new InvalidOperationException("Dialog is already shown.");
 
             _taskCompletionSource = new TaskCompletionSource<object>();
             ShowDialogInternal(parent);
@@ -176,7 +176,7 @@ public async Task ShowDialogAsync(Control parent)
         public async Task<T> ShowDialogAsync<T>(Control parent)
         {
             if (_taskCompletionSource != null)
-                throw new NotImplementedException();
+                throw new InvalidOperationException("Dialog is already shown.");
 
             _taskCompletionSource = new TaskCompletionSource<object>();
             ShowDialogInternal(parent);

diff --git a/src/Consolonia.Core/Controls/FileOpenPicker.axaml.cs b/src/Consolonia.Core/Controls/FileOpenPicker.axaml.cs
@@ -1,3 +1,4 @@
+using System;
 using Avalonia.Controls;
 using Avalonia.Input;
 using Avalonia.Interactivity;

diff --git a/src/Consolonia.Core/Controls/FileSavePickerViewModel.cs b/src/Consolonia.Core/Controls/FileSavePickerViewModel.cs
@@ -24,7 +24,7 @@ protected override bool FilterItem(IStorageItem item)
             if (item is IStorageFolder) return true;
             if (item is IStorageFile file)
             {
-                if (SelectedFileType.Patterns == null || SelectedFileType.Patterns.Count == 0)
+                if (SelectedFileType?.Patterns == null || SelectedFileType.Patterns.Count == 0)
                     return true;
 
                 foreach (string pattern in SelectedFileType.Patterns)

diff --git a/src/Consolonia.Core/Infrastructure/ConsoloniaStorageProvider.cs b/src/Consolonia.Core/Infrastructure/ConsoloniaStorageProvider.cs
@@ -82,7 +82,7 @@ public Task<IStorageFolder> TryGetWellKnownFolderAsync(WellKnownFolder wellKnown
             {
                 WellKnownFolder.Desktop => Environment.GetFolderPath(Environment.SpecialFolder.Desktop),
                 WellKnownFolder.Documents => Environment.GetFolderPath(Environment.SpecialFolder.MyDocuments),
-                WellKnownFolder.Downloads => Environment.GetFolderPath(Environment.SpecialFolder.UserProfile),
+                WellKnownFolder.Downloads => Path.Combine(Environment.GetFolderPath(Environment.SpecialFolder.UserProfile), "Downloads"),
                 WellKnownFolder.Pictures => Environment.GetFolderPath(Environment.SpecialFolder.MyPictures),
                 WellKnownFolder.Music => Environment.GetFolderPath(Environment.SpecialFolder.MyMusic),
                 WellKnownFolder.Videos => Environment.GetFolderPath(Environment.SpecialFolder.MyVideos),

diff --git a/src/Consolonia.Gallery/Gallery/GalleryViews/GalleryStorage.axaml.cs b/src/Consolonia.Gallery/Gallery/GalleryViews/GalleryStorage.axaml.cs
@@ -106,7 +106,7 @@ private async void OnSaveFile(object sender, Avalonia.Interactivity.RoutedEventA
             if (lifetime != null)
             {
                 var storageProvider = lifetime.MainWindow.StorageProvider;
-                if (storageProvider.CanOpen)
+                if (storageProvider.CanSave)
                 {
                     var file = await storageProvider.SaveFilePickerAsync(new FilePickerSaveOptions()
                     {

diff --git a/src/Consolonia.NUnit/UnitTestConsole.cs b/src/Consolonia.NUnit/UnitTestConsole.cs
@@ -94,9 +94,9 @@ public async Task StringInput(string input)
                 // todo: check why Yield is not enough: https://github.com/jinek/Consolonia/runs/7055199426?check_suite_focus=true
                 const ulong interval = 50;
                 KeyEvent?.Invoke(key, c, RawInputModifiers.None, true, timestamp);
-                await Task.Delay((int)interval);
+                await Task.Delay((int)interval).ConfigureAwait(false);
                 KeyEvent?.Invoke(key, c, RawInputModifiers.None, false, timestamp + interval);
-                await Task.Delay((int)interval);
+                await Task.Delay((int)interval).ConfigureAwait(false);
             }
 
             await WaitRendered().ConfigureAwait(true);