Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in project resource #154

Closed
3 tasks done
ljupchokotev opened this issue Aug 12, 2024 · 1 comment
Closed
3 tasks done

Breaking change in project resource #154

ljupchokotev opened this issue Aug 12, 2024 · 1 comment
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@ljupchokotev
Copy link

ljupchokotev commented Aug 12, 2024

Describe the bug
The project resource has introduced attributes like use_project_repository_resource which is set to true by default, meaning existing code will break as the repos attribute will be ignored.

This was added in a minor version change. I would expect these new attributes to be set to false by default, and changed to true only in a major version update.

Requirements for and issue

  • A fully functioning terraform snippet that can be copy&pasted (no outside files or ENV vars unless that's part of the issue): Nothing to do with a Terraform configuration, just any project_project resource which uses repos.
  • Your version of artifactory (you can curl it at $host/artifactory/api/system/version: 7.84.20
  • Your version of terraform: 1.6.6

Expected behavior

A minor version upgrade of a provider should not introduce breaking changes. The repos attribute should still be functional even though it is deprecated.

Additional context

@ljupchokotev ljupchokotev added the bug Something isn't working label Aug 12, 2024
@alexhung
Copy link
Member

@ljupchokotev You're correct that it should have been a major version change when the update was originally released. My apology on that mistake.

The reason behind use_project_repository_resource attribute default to being true is that the repos attribute is not a good solution. The new project_repository resource is a huge improvement and thus we were actively trying to discourage any new users from using repos attribute.

We feel that the trade off of requiring the addition of use_project_repository_resource = true was minor and acceptable to speed up adaption of project_repository resource while allowing existing users to continue using repos attribute until they migrate.

@alexhung alexhung added the wontfix This will not be worked on label Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants