Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New OIDC fields added, including the GitHub job name and run ID #225

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

EyalDelarea
Copy link
Contributor

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • I used npm run format for formatting the code before submitting the pull request.

Add new fields to the OIDC token exchange.

gh_job_id- The job_id of the current job. For example, greeting_job.
gh_run_id - A unique number for each workflow run within a repository. This number does not change if you re-run the workflow run. For example, 1658821493.

@EyalDelarea EyalDelarea added the improvement Automatically generated release notes label Nov 14, 2024
@EyalDelarea EyalDelarea added the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 14, 2024
@eyalbe4 eyalbe4 changed the title Add OIDC fields New OIDC fields added, including the GotHub job ID and run number Nov 29, 2024
@eyalbe4 eyalbe4 changed the title New OIDC fields added, including the GotHub job ID and run number New OIDC fields added, including the GitHub job ID and run number Nov 29, 2024
@eyalbe4 eyalbe4 changed the title New OIDC fields added, including the GitHub job ID and run number New OIDC fields added, including the GitHub job name and run ID Nov 29, 2024
@eyalbe4 eyalbe4 marked this pull request as ready for review November 29, 2024 06:27
@eyalbe4 eyalbe4 added the safe to test Approve running integration tests on a pull request label Nov 29, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 29, 2024
@eyalbe4 eyalbe4 merged commit 73cafc9 into jfrog:master Nov 29, 2024
33 of 34 checks passed
@eyalbe4 eyalbe4 added ignore for release Automatically generated release notes and removed improvement Automatically generated release notes labels Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release Automatically generated release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants