From c398de0296e8be71642fcaf16be6531f57724802 Mon Sep 17 00:00:00 2001
From: Basil Crow <me@basilcrow.com>
Date: Sun, 20 Oct 2024 09:25:08 -0700
Subject: [PATCH] Clean up PMD configuration

---
 .pmd.config.xml | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/.pmd.config.xml b/.pmd.config.xml
index d9076e7..d6240f7 100644
--- a/.pmd.config.xml
+++ b/.pmd.config.xml
@@ -27,8 +27,6 @@
         <exclude name="AtLeastOneConstructor" />
         <!-- This complains about variable names like 'id' -->
         <exclude name="ShortVariable" />
-        <!-- This rule makes no sense -->
-        <exclude name="AvoidFinalLocalVariable" />
     </rule>
     <rule ref="category/java/design.xml">
         <exclude name="CognitiveComplexity" />
@@ -37,11 +35,7 @@
         <exclude name="LawOfDemeter" />
         <exclude name="LoosePackageCoupling" />
     </rule>
-    <rule ref="category/java/errorprone.xml">
-        <!-- Produces lots of false positives and the Java
-             compiler catches most of these anyway -->
-        <exclude name="DataflowAnomalyAnalysis"/>
-    </rule>
+    <rule ref="category/java/errorprone.xml"/>
     <rule ref="category/java/multithreading.xml"/>
     <rule ref="category/java/performance.xml">
         <exclude name="AvoidCalendarDateCreation" />