Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support publishing failed runs #93

Open
jelmer opened this issue Oct 2, 2022 · 3 comments
Open

support publishing failed runs #93

jelmer opened this issue Oct 2, 2022 · 3 comments
Labels
janitor.kali.org To do with the Kali Janitor instance

Comments

@jelmer
Copy link
Owner

jelmer commented Oct 2, 2022

at the moment, runs have to completely succeed to build before they're considered for publishing.

in some cases, we may still want to publish even when builds failed. See https://salsa.debian.org/jelmer/janitor/-/issues/204 for background.

See also #90, which is a prerequisite for this.
@jelmer jelmer added the janitor.kali.org To do with the Kali Janitor instance label Oct 2, 2022
@jelmer
Copy link
Owner Author

jelmer commented Oct 27, 2022

Maybe we should even considering pushing right after the codemod has run?

@jelmer
Copy link
Owner Author

jelmer commented Nov 20, 2022

Maybe we should even considering pushing right after the codemod has run?

This is now implemented.

@jelmer
Copy link
Owner Author

jelmer commented Jan 9, 2023

Next steps are probably:

  • have kali_janitor.followup set review_status="approved" for runs that should be published
  • publish should publish anything that is approved, regardless of the result code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
janitor.kali.org To do with the Kali Janitor instance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jelmer