Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

Created an Addons section #682

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

DevilsDesigns
Copy link

I originally added a github repo stars in plugins. I decided to add an addons repo with all the possible addons not already listed in jellyfins docs. I figured this was best since it didnt fit any of the other categories and to make it simpler for people to find what they want in the least amount of clicks.

I originally added a github repo stars in plugins. I decided to add an addons repo with all the possible addons not already listed in jellyfins docs. I figured this was best since it didnt fit any of the other categories and to make it simpler for people to find what they want in the least amount of clicks.
Copy link
Contributor

@TimGels TimGels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I currently don't have time to read all of it. But I found a couple of spelling errors and added some suggestions which you might want to look into.

Furthermore, I think adding a general introduction to this page to let the user know what it is about and what addons are might also be a nice addition to consider.

general/server/plugins/addons.md Outdated Show resolved Hide resolved
general/server/plugins/addons.md Outdated Show resolved Hide resolved
edited some grammar corrections
added introduction to the page
@whiteowl3
Copy link

#688
Please consider using "add-ons" as this is technically correct in English.

edited speech for add-ons
@DevilsDesigns
Copy link
Author

made the required edits

#688 Please consider using "add-ons" as this is technically correct in English.

general/server/plugins/add-ons.md Outdated Show resolved Hide resolved
general/server/plugins/add-ons.md Outdated Show resolved Hide resolved
general/server/plugins/add-ons.md Outdated Show resolved Hide resolved
general/server/plugins/add-ons.md Outdated Show resolved Hide resolved
@TimGels
Copy link
Contributor

TimGels commented Jul 13, 2022

None of the projects listed here get installed as a plugin, so they do not fit in with the others on the plugin section, right?

I also wonder if "add-on" is a term that captures these projects accurately with how they are related to and used with Jellyfin, but that could be just me wondering for no reason, as I currently do not know a better alternative name myself. Might be interesting what other contributors think of this section and the name.

fixed grammar corrections in the pull comments
@DevilsDesigns
Copy link
Author

None of the projects listed here get installed as a plugin, so they do not fit in with the others on the plugin section, right?

I also wonder if "add-on" is a term that captures these projects accurately with how they are related to and used with Jellyfin, but that could be just me wondering for no reason, as I currently do not know a better alternative name myself. Might be interesting what other contributors think of this section and the name.

Correct thats why i made a new section because they wouldnt fix in the plugins section. I was figuring if it wasnt add-ons it would have been extensions but that i feel doesnt fit as good as add-ons because that means their something you can addon to your jellyfin install. Also I made the required edits.

@TimGels
Copy link
Contributor

TimGels commented Jul 13, 2022

None of the projects listed here get installed as a plugin, so they do not fit in with the others on the plugin section, right?
I also wonder if "add-on" is a term that captures these projects accurately with how they are related to and used with Jellyfin, but that could be just me wondering for no reason, as I currently do not know a better alternative name myself. Might be interesting what other contributors think of this section and the name.

Correct thats why i made a new section because they wouldnt fix in the plugins section. I was figuring if it wasnt add-ons it would have been extensions but that i feel doesnt fit as good as add-ons because that means their something you can addon to your jellyfin install. Also I made the required edits.

I asked around with other contributors and names like "integrations", "third-party software", "third-party integrations" and "works with Jellyfin" also came up as possible alternative names. I personally like third-party software or third-party integrations myself (but that is just my personal opinion). These names capture this section better I think. What do you think of these names?

- Moved Addons in plugins directory to contributing to a new md called Third-Party Integrations
- Replaced Addons with Third-Party Integrations in docs
- Moved add-ons section to contributing and called it Third-Party Integrations
- Deleting Addons in Plugins section
@DevilsDesigns
Copy link
Author

None of the projects listed here get installed as a plugin, so they do not fit in with the others on the plugin section, right?
I also wonder if "add-on" is a term that captures these projects accurately with how they are related to and used with Jellyfin, but that could be just me wondering for no reason, as I currently do not know a better alternative name myself. Might be interesting what other contributors think of this section and the name.

Correct thats why i made a new section because they wouldnt fix in the plugins section. I was figuring if it wasnt add-ons it would have been extensions but that i feel doesnt fit as good as add-ons because that means their something you can addon to your jellyfin install. Also I made the required edits.

I asked around with other contributors and names like "integrations", "third-party software", "third-party integrations" and "works with Jellyfin" also came up as possible alternative names. I personally like third-party software or third-party integrations myself (but that is just my personal opinion). These names capture this section better I think. What do you think of these names?

I love your suggestions way more professional and way easier to understand the naming. I changed the Documentations titles to Third-Party Integrations and moved it to the contributions section of the documentation. I also deleted the original Add-ons Section in Plugins documentation in place for the Contributions/Third-Party-Integrations.md. Let me know if we can push this through or any other edits need to be made. I also changed all forms of Add-ons text to Third-Party Integrations

general/contributing/Third-Party Integrations.md Outdated Show resolved Hide resolved
general/contributing/Third-Party Integrations.md Outdated Show resolved Hide resolved
general/contributing/Third-Party Integrations.md Outdated Show resolved Hide resolved
general/contributing/Third-Party Integrations.md Outdated Show resolved Hide resolved
@TimGels
Copy link
Contributor

TimGels commented Jul 20, 2022

I love your suggestions way more professional and way easier to understand the naming. I changed the Documentations titles to Third-Party Integrations and moved it to the contributions section of the documentation. I also deleted the original Add-ons Section in Plugins documentation in place for the Contributions/Third-Party-Integrations.md. Let me know if we can push this through or any other edits need to be made. I also changed all forms of Add-ons text to Third-Party Integrations

I don't see a contributing uid being used anywhere else. This one also isn't added to the toc file. So it will not be visible. I also don't know if I like this place for third-party software as it is more geared towards getting people to understand how they can contribute to Jellyfin, rather than seeing what software works with Jellyfin. I suggest you to ask what other people's opinions are on a fitting place for this page.

@DevilsDesigns
Copy link
Author

i made all the gramatical corrections. I also added it to toyc and its referenced. Could be more specific about asking the community. Who should I ask, and where should? Let me know if anything other ideas you may have?

@TimGels
Copy link
Contributor

TimGels commented Jul 21, 2022

i made all the gramatical corrections. I also added it to toyc and its referenced. Could be more specific about asking the community. Who should I ask, and where should? Let me know if anything other ideas you may have?

You are active on Matrix / Discord in the development channel. I think thats a good place to ask. I also asked yesterday and i got a response saying that it could also possibly fit in its own category all together. Which I agree with too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants