Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate magic train untrain methods #140

Open
2 of 3 tasks
ibnesayeed opened this issue Jan 18, 2017 · 10 comments
Open
2 of 3 tasks

Deprecate magic train untrain methods #140

ibnesayeed opened this issue Jan 18, 2017 · 10 comments

Comments

@ibnesayeed
Copy link
Contributor

ibnesayeed commented Jan 18, 2017

Before releasing 2.2.0 magical train_* and untrain_* style methods should be deprecated.

  • Add deprecation warning
  • Add tests to not use these methods
  • Update documentation to not use these methods
@ibnesayeed
Copy link
Contributor Author

It would also be good to have the official development Docker image available (#101) before the release of 2.2.0 so that it can be documented and advertised with this rather significant release.

@ibnesayeed
Copy link
Contributor Author

Perhaps we can also include basic validation #71 as part of 2.2.0 release.

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 18, 2017

Sounds good. I have a working branch for the first two items. I'll push it up later.

@ibnesayeed
Copy link
Contributor Author

I can take care of the documentation, later tonight.

@ibnesayeed
Copy link
Contributor Author

PR #141 takes care of the documentation.

@ibnesayeed
Copy link
Contributor Author

@Ch4s3 a note for you. I have seen test_external_classifying of lsi_test.rb using magic methods. Just make sure to take care of all the places where Bayes is being called with magic methods.

@Ch4s3
Copy link
Member

Ch4s3 commented Jan 21, 2017

Yeah, that's on the list. I'll try to devote some time to this tomorrow or Monday.

@Ch4s3
Copy link
Member

Ch4s3 commented Feb 8, 2017

I'll try to get back to this asap

@ibnesayeed
Copy link
Contributor Author

@Ch4s3 please take care of the second point on the original post of this ticket before releasing 2.2.0 as per #164. This should be pretty easy and quick to deal with.

@Ch4s3
Copy link
Member

Ch4s3 commented Aug 2, 2017

@ibnesayeed will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants