Skip to content
This repository has been archived by the owner on Apr 30, 2019. It is now read-only.

AVL tree? #25

Closed
jeffhammond opened this issue Sep 21, 2018 · 3 comments
Closed

AVL tree? #25

jeffhammond opened this issue Sep 21, 2018 · 3 comments
Assignees

Comments

@jeffhammond
Copy link
Owner

AVL tree will be faster than linked-list traversal for GMR lookup.

https://github.com/freebsd/freebsd/blob/master/sys/cddl/contrib/opensolaris/common/avl/avl.c exists but I do not know if CDDL is acceptable in ARMCI-MPI. If not, we'll have to implement from scratch.

@jeffhammond jeffhammond self-assigned this Sep 21, 2018
@jdinan
Copy link
Collaborator

jdinan commented Sep 21, 2018

Fortunately, ARMCI-MPI already has an AVL tree: https://github.com/jeffhammond/armci-mpi/blob/master/src/conflict_tree.c

Not sure why I didn't use this for GMR lookups. I suspect the reason is that when the number of memory regions is small, the performance improvement is negligible.

@jeffhammond
Copy link
Owner Author

jeffhammond commented Sep 21, 2018 via email

@jeffhammond
Copy link
Owner Author

Migrated to pmodels/armci-mpi#18

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants