Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Change e_scale parameter and CatalogEntry.gal_scale from pixels to degrees #680

Open
kbarbary opened this issue Aug 11, 2017 · 0 comments
Assignees

Comments

@kbarbary
Copy link
Collaborator

kbarbary commented Aug 11, 2017

Nearly all the parameters of the model and CatalogEntry are given in world coordinates, independent of image pixel scale or WCS. For example, the position is given in (RA, Dec), not (x, y) pixel position. This makes sense because a single source may occur on multiple images, potentially with different pixel scales.

However, CatalogEntry.gal_scale seems to be an exception, being given in pixels. This (and the e_scale model parameter) should be changed to units of degrees.

Thoughts?

@kbarbary kbarbary changed the title Change e_scale parameter and CatalogEntry.gal_scale from pixels to degrees RFC: Change e_scale parameter and CatalogEntry.gal_scale from pixels to degrees Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant