Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Details pane scrollable and panes resizable and reorientable #35

Open
Elcoid opened this issue Jul 15, 2021 · 3 comments
Open

Make Details pane scrollable and panes resizable and reorientable #35

Elcoid opened this issue Jul 15, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@Elcoid
Copy link

Elcoid commented Jul 15, 2021

First of all, thank you for making ShellCaster! It is very simple and intuitive, I like it.
Here are three suggestions to improve it:

  • The details pane should be scrollable. Some podcasts come with long descriptions or sometimes with the close captioning of the audio. See for example this screenshot, on the bottom right:
    ksnip_20210715-155952
    When an item in the middle pane is selected, pressing right or l could highlight the right pane and allow to scroll with up/down or j/k.
  • The panes should be resizable. In the screenshot above, we see that some episode names in the middle pane are cut. Widening the middle pane would solve the issue.
  • Alternatively, the problem of cut names could be solved (unless the episode names are really too long) by allowing the user to make the panes horizontal and stacked one above the other. In this configuration, the same keys could be used to move from one pane to an other (left/right or h/l) and within the panes (up/down or j/k).
@jeff-hughes
Copy link
Owner

Thanks for the suggestions! I like the idea of the scrollable descriptions. I guess none of the podcasts that I subscribe to tend to have their transcripts directly in the description (I've seen some with links to show notes that have a transcript), so it's not something I had considered. But I like the idea! Especially for the one you're showing in the screenshot where if you're trying to learn German, the transcript might be helpful for following along. So I'll add it to my list.

As far as the resizable panes or switching vertical to horizontal....I'm not quite as keen on those, as I think they would end up creating a fair amount of complexity. The app has too many keybindings as it is! I'm not convinced that the episode names being cut off is a particularly big problem, as the full episode name appears in the details pane on the right already. I get that it's only showing the currently selected episode, but I think trying to build in resizable panes would create a lot of complexity without a great return on investment there. You called shellcaster "simple and intuitive", and that's the sweet spot where I'd like to keep it!

I will play around with the horizontal/vertical idea a bit more, see if I can get something useful working. I could see it being beneficial for people with monitors oriented vertically. The awkward thing might be that your "left" and "right" keybindings now really are moving the cursor up and down instead (from one pane to the next) in that layout, and maybe that just ends up being weird. But I'll at least play around with it and see if there's something useful there.

Thanks again for the suggestions!

@jeff-hughes jeff-hughes added the enhancement New feature or request label Jul 18, 2021
@enron-hubbard
Copy link

For reorienting panels, this could be done in the config without having to set any new keybindings. Tut has a nice approach to it, setting variables for panel placement and proportional sizes using two panels (list and content):

list-placement=[top,bottom,left,right]
list-proportion=[x]
content-proportion=[x]

You could do the same kind of thing in the config. For example:

layout=horizontal
podcasts-placement=left
podcasts-proportion=1
episodes-placement=middle
episodes-proportion=1
details-placement=right
details-proportion=1

is the layout as it already is. Or you could do:

layout=vertical
podcasts-placement=top
podcasts-proportion=1
episodes-placement=bottom
episodes-proportion=1
details-placement=middle
details-proportion=3

to have a portrait view with the podcast list at the top, episodes at the bottom, and a big fat details pane right in the middle.

@arza-zara
Copy link

Scrollable details was implemented in 3bca021.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants