Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset sim thermocouple (or cool naturally) when in idle with simulation mode #191

Open
solnus opened this issue Aug 25, 2024 · 2 comments
Open
Labels

Comments

@solnus
Copy link
Contributor

solnus commented Aug 25, 2024

When running with sim mode, the temp reaches the target and never resets, disallowing running another simulated schedule without restarting the service. I would propose one of two approaches - either just reset to environment temp after reaching idle, or continue "natural" cooling rate even in idle (with speedup factor accounted for).

@jbruce12000
Copy link
Owner

super low priority. work-around is to re-start the process. most folks will simulate to decide whether to use the software or not - assess features, and then move on to the work of implementing the hardware.

PR welcome. this should be just a few line change I'd expect.

@solnus
Copy link
Contributor Author

solnus commented Aug 25, 2024

Agree low priority, just want to track it. I may get to it eventually but not currently familiar enough with the code base to find the right place to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants