Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add svg icons from Django 1.9 and use static function #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

claudep
Copy link
Collaborator

@claudep claudep commented Nov 3, 2016

Fixes #172.

@coveralls
Copy link

coveralls commented Nov 3, 2016

Coverage Status

Coverage increased (+0.03%) to 89.679% when pulling 93c0e57 on claudep:svg_icons into 323dc20 on dokterbob:master.

@dokterbob
Copy link
Collaborator

Thanks! If wait and submit aren't there yet, perhaps we should not close the SVG ticket altogether.

Any chance we could find equivalent SVG icons for these messages to fully finish this off?

@claudep
Copy link
Collaborator Author

claudep commented Mar 28, 2017

It shouldn't too hard to convert waiting.gif to svg, but submitting.gif is animated, so it's trickier to convert (don't know the status of animated SVG in current browsers).

@dkdndes
Copy link

dkdndes commented Jun 27, 2017

@DoctorBob if you are willing to add a non-standard lib, then check out https://loading.io/spinner/ - It would enable you to add a animated svg Icon.

@dokterbob
Copy link
Collaborator

@dkdndes Sounds like overkill to me.

Couldn't we just use one of their spinners and copy it as a direct replacement?

@dokterbob
Copy link
Collaborator

I guess the simplest option would be to add a static SVG spinner image and then use stepped CSS animation to animate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants