Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Games with non-english characters fail to launch (ie + and ') #5

Open
benspray opened this issue Jan 5, 2024 · 3 comments
Open

Games with non-english characters fail to launch (ie + and ') #5

benspray opened this issue Jan 5, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@benspray
Copy link

benspray commented Jan 5, 2024

Hi, Just started using this rather than manually configuring everything and its looking good thanks. However one issue I have come across is when a file has a character such as + or ' in the name the argument that gets passed seems to break, the launch window closes too fast for me to catch but I guess its something to do with the emulator argument and how it uses the {imagepath} variable?
I'd rather not rename my roms as they are named as per romvault datfile standards ;)

Regards

@benspray benspray changed the title Games with non-english characters fail to launch Games with non-english characters fail to launch (ie + and ') Jan 5, 2024
@jackgllghr
Copy link
Owner

Hi, thanks for giving it a go! Yeah my guess is it's an escaping issue I've missed, right here at Line 115:

https://github.com/jackgllghr/PlayniteEmudeck/blob/main/Emudeck/EmudeckConfigurator.cs

I'm a bit swamped at the moment but I'll try and get to it soon but happy to accept PRs

@jackgllghr jackgllghr added the bug Something isn't working label Jan 25, 2024
@jackgllghr
Copy link
Owner

jackgllghr commented Jan 25, 2024

This one's tricky, we might need to sanitize the inputs by passing all the arguments into a bash script of our own, as right now we don't have the {ImageDir} to work with.

So it'd go
Launch Game > Passes all args to our sanitising script > which passes all args sanitised to emudeck powershell script

Not the most elegant solution but I'll take a look

image

@benspray
Copy link
Author

Hi, any updates :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants