Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Bolts-ObjC to Promises #5

Open
iyegoroff opened this issue Dec 19, 2018 · 3 comments
Open

Switch from Bolts-ObjC to Promises #5

iyegoroff opened this issue Dec 19, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@iyegoroff
Copy link
Owner

iyegoroff commented Dec 19, 2018 •
edited
Loading

Currently this module uses Bolts-ObjC under the hood. This fact could be a no go for some users because of it's BSD + PATENTS style license. Google's Promises library seems like a good alternative to Bolts-ObjC.

However, this is not a big deal right now (December 19, 2018) because react-native itself still uses a BSD + PATENTS licensed version of Bolts-Android via Fresco dependency.

Related issues:
BoltsFramework/Bolts-ObjC#319
BoltsFramework/Bolts-Android#151
facebook/fresco#2257
@iyegoroff iyegoroff added enhancement New feature or request good first issue Good for newcomers labels Dec 19, 2018
@Benjamin-Willard

This comment has been minimized.

Sign in to view
@dkfl1995

This comment has been minimized.

Sign in to view
@iyegoroff

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Benjamin-Willard @iyegoroff @dkfl1995