-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Numpy + OpenCV autodetection to SCons #173
base: main
Are you sure you want to change the base?
Conversation
else: | ||
print("Numpy not found. Attempting to autodetect...") | ||
try: | ||
import numpy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is tricky because scons could be using a different python version than the one being used for installation - notably macports. Its lot easier with cmake to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think I have always used the scons from Python2. Not sure why I got started with that, but I never changed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Unless you know how to have scons invoke the python used for installation, maybe I should just disable this when scons is using python 2.
Hmm, I removed opencv from from the installation prereq list to test the autodetect fallback, but dependency resolution still failed. Is there another package conflict occurring in our prereqs? |
hdf5 might need to be pinned. I think the new version still hasnt propagated to all the feedstocks. |
We also had a problem with HDF5 library requirement. @nicodalse had installed the ISCE2 requirements with conda and did a build. The resulting executables were pulling in an HDF5 library from /lib64 on our Linux server instead of using the one from his conda installation. I don't know if this is the same problem. I recommended that he try using |
Yes, opencv gave me a lot of conflicts and the hdf5 library get me this error also in a new virtual env:
|
these errors seem to be driver driven due to environment issues and not due to conda. The conda issue is that none of the package versions are pinned and there should be no issues if they are pinned like it is done on raider / mintpy. Quickest way is to see dependencies used by isce2 conda package and use same package versions for hdf5 and gdal. |
I heard from @nicodalse that he was able to merge my |
b82bfe1
to
379e913
Compare
@EJFielding @leiyangleon