Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra_reference_date logic for single reference unwrapping #497

Merged

Conversation

scottstanie
Copy link
Collaborator

@scottstanie scottstanie commented Nov 22, 2024

The current logic correctly relabelled the interferograms across the reference-date change; however it used the same reference phase (by using convert_pl_to_ifg) and didn't apply the new reference phase.

The other change is to fix the unclear logic about when to apply the reference date, if it's supplied: the only times we ignore during wrapped_phase are if we're using spurt (i.e. is_using_spurt) or if we've requested nearest-3/nearest-n interferograms (is_using_short_baseline_ifgs). The logic looks different because the old one was subtly wrong, but just didn't come up in practice.

@scottstanie scottstanie marked this pull request as ready for review November 23, 2024 01:48
@scottstanie scottstanie merged commit 1ff9099 into isce-framework:main Nov 23, 2024
5 checks passed
@scottstanie scottstanie deleted the fix-single-day-re-reference branch November 23, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant