Ongoing enablement & tweaks for v2

[tevpg]

implementation

• db loading pipeline for prod
• rebuild prod db (bec previous duration calculations are wrong)
• more registration sounds

Bugs and minor enhancements

• check estimator logic - appears to be ignoring time_closed parameter
• notes get folded all to LC as part of token management. This is an annoyance more than a bug, but it is an annoyance
• web Audit shows different (& bogus) results than client audit (screenshot) -- HIGH PRIORITY
  • client matches json & this also seems correctly reflected in web summary page
  • seems like it's just the web audit page
• something checked in & out (or out & in?) in same minute does not show its latest state in the TAGS matrix (screen shot on phone)
• when taglist to a command has duplicates, then system hangs. Better to say "ignoring duplicate of "wa3""
• change VTime to have 1-second granularity. Can I make this completely internal so it doesn't show up in text representations but is used in compares? Also, would want granularity preserved in json files (& database?) -- this is Change to second (not minute) precision #435
• recent with two timestamps seems to ignore first one, starts at start of day
• allow reuse in same minute it was checked out (see also: VTime granularity)
• day detail has no buttons or message when there is no data for a day
• add links to day detail in main page summary table headings
• read git version. this may be a problem that is not reasonably tractable
• dat_to_json - if can't write file (permission error) it doesn't notice. This might be part of TrackerDay.save_to_file() (or whatever) so check it well
• Prev/(Next?) day in day_detail does not advance days if there's more than one orgsite_id's worth od day data
• if start/end time > closing time then duration ends up null, which causes grief down the line. db_from_datafile.
• PeriodDetail has different field names than database BLOCK table, & does not have fullest for REG/OVR
• db loader: add finally: cursor.close() when catching DB error exceptions
  to (time)
  to Registrations being a free-floating class not an instance within TrackerDay
  now that notes are part of TrackerDay
• NB a bike is present at the moment of its check-in up to but not including the time of its check-out. This will be important for moment state and for totals but not for 'recent'
• consider adding bike_type to BikeVisit for simplicity in acces.
• add a method to fill in missing portions of a trackerday from config. This applies to conversions from old datafiles and initialization of a new day, and would incorporate reading tagid lists from config. Part of this will be an olddatafile --> newdatafile mapping. THink about this in the context of regular use & also converting DAT to JSON

Lint checking

• load from file: do a date & open/close time check at load time
• db load. if an item (e.g. site_handle) is missing, crashes rather than errors out
• lint: look for bikes well outside operating hours. Also do this check when changing hours.
• lint check that bike_type matches betw visit and BikeTag
• reading, check that all visits for a given tag are of the same bike_type
• doesn't care if site_name (etc) are empty as long as they're present. Add to lint check.

Larger ideas including science projects

• internet monitor continues to have false positives
• consider 'disable' (&'enable') commands to take tags out of service (same day only). Eg if it's a small gap left by a scooter. Req changes to JSON and to BikeTag statuses, plus rules about when can be disabled (ie not if IN_USE).
• consider a command that would clear tag(s) for re-use. This would require a different category in 'audit', a different command, plus an additional status value for a BikeTag. For the time being, reserve the word 'reuse' as a possble command. (Others: recycle? ...?)
• [ ]