Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CLI (version) configureable #6

Open
StefMa opened this issue Feb 24, 2023 · 0 comments
Open

Make CLI (version) configureable #6

StefMa opened this issue Feb 24, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@StefMa
Copy link
Collaborator

StefMa commented Feb 24, 2023

Currently the CLI version is hardcoded:

private fun findSentryCliDownloadUrl(): String {
val osName = System.getProperty("os.name").lowercase(Locale.ROOT)
return when {
osName.contains("mac") ->
"https://github.com/getsentry/sentry-cli/releases/download/2.12.0/sentry-cli-Darwin-arm64"
osName.contains("nix") || osName.contains("nux") || osName.contains("aix") ->
"https://github.com/getsentry/sentry-cli/releases/download/2.12.0/sentry-cli-Linux-x86_64"
else -> throw GradleException("We do not support $osName")
}
}

We should make it possible that plugin consumers can change the version via extensions (see also #4).

To note:
Updating the version of the CLI might break the uploading in case the CLI parameters change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant