-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RN 0.76+ Android + old-arch only - opening notification when the app is killed crashes on start #8131
Comments
Huh - I've only checked 0.76.n with turbomodules working |
Not easy to test this stuff! Luckily I have a big stack of issues related to FCM so I went ahead and set up some scaffolding in #8143 and on https://github.com/mikehardy/rnfbdemo/blob/main/make-demo.sh (on a branch unpushed so not visible yet), so I can now test this stuff. This is largely repetitive but here is what I see when I follow these steps:
So I did not see exactly what you saw, but I saw something... No investigation yet but reproduction is frequently 90% of the problem with things like this crash trace logcat output
|
Some more subtleties while testing:
Recompiling with newArchEnabled=true works to bring the functionality back, but this may understandably be a problem for some |
Upstream: facebook/react-native#47592 |
It seems a bit strange but... if you leave the notification in the notification center, without clearing it, and try to open the app, the crash occurs. At least here it is happening like that. |
There are many crashes in production for us, all the reports from the users are aligned with what i reported above. App is not in the background. The user tap on the notification from the tray and the app crashes on start. Downgrading to RN 0.75.n solves the problem. |
@oraylan that's bizarre - tougher to reproduce as well, I was able to see it the first time I tried, then it failed the next 3 times. So your report is inconsistent but I did see it. Here's the trace I got when that crash happened, repro was:
crash trace logcat output
This looks like the important line:
|
[Edit - maintainer update: upstream issue - facebook/react-native/issues/47592 - workaround - use new architecture 0.76.1+ for background FCM to work]
Crashes with EarlyJsError: TurboModuleRegistry.getEnforcing(...): 'PlatformConstants' could not be found. Verify that a module by this name is registered in the native binary.
Only checked with new architecture disabled.
The text was updated successfully, but these errors were encountered: