Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messages #86

Open
jameysharp opened this issue Mar 24, 2023 · 1 comment
Open

Better error messages #86

jameysharp opened this issue Mar 24, 2023 · 1 comment

Comments

@jameysharp
Copy link

Currently, the Rust JIT profiling API can only report an error with message "error when notifying event". That doesn't give me much to go on when troubleshooting, especially when all I have is this message and a stack trace reported by somebody else.

At minimum I think it would help if it called iJIT_IsProfilingActive and returned a different error message when loading the shared library failed, as opposed to something else going wrong.
@abrown
Copy link
Contributor

abrown commented Mar 29, 2023

Sounds good to me; better error messages in various places would be appreciated! Do you feel OK submitting a PR for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@abrown @jameysharp