Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor things and fix the spaghetti #10

Open
taotriad opened this issue Apr 21, 2023 · 5 comments
Open

Refactor things and fix the spaghetti #10

taotriad opened this issue Apr 21, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@taotriad
Copy link
Contributor

All libraries should be refactored to remove the worst cases of spaghetti code.

Desired outcome:

  • Executables and their includes should be able to be installed according to FHS on a Linux system.
  • It should be possible to build .deb packages that follow the Debian packaging policy for python software.
@taotriad taotriad self-assigned this Sep 13, 2023
@taotriad taotriad added the enhancement New feature or request label Sep 13, 2023
@dweineha
Copy link
Contributor

dweineha commented Feb 2, 2024

Additional requirements:

  • Libraries SHOULD not call sys.exit() or print messages; they should raise exceptions, and wherever feasible use strings formatted with List[ANSIThemeString] as extra arguments to the exceptions (only works for our custom exceptions).
  • Libraries MUST not have circular dependencies; define acceptable dependencies and stick to them

@taotriad
Copy link
Contributor Author

This is WIP.

@taotriad
Copy link
Contributor Author

While refactoring has not been fully completed yet, the systempath branch should now support installing to, and working from, the system path. There are probably still things to consider, but we're close to the point where we could consider creating .deb packages.

@dweineha
Copy link
Contributor

The systempath branch has been merged into main. Future development will continue in the main branch.

@taotriad
Copy link
Contributor Author

All remaining infogetters have been split from cmu and moved into infogetters.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants