Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

push command with -r prints the full remote url which may contain credentials #589

Open
eslamkarim opened this issue Jun 9, 2023 · 2 comments
Labels

Comments

@eslamkarim
Copy link

While using git subrepo in a ci/cd tool we had to use -r/--remote while pushing with credentials as variables but the output of the command just prints the full url without hiding the credentials

there might be a better way to hide our credentials but i think it might still be a good idea to fix.

@admorgan admorgan added the Bug label Jun 9, 2023
@admorgan
Copy link
Collaborator

admorgan commented Jun 9, 2023

Absolutely a bug. Can you give me a sample, with fake credentials, of how you are calling it so I can create a test? I don't think I have ever included credentials in my URL.

@eslamkarim
Copy link
Author

example command and output:

git subrepo push subdir --branch=dev -r https://$GH_USER:$GH_PWD@github.com/ingydotnet/git-subrepo.git

Subrepo 'subdir' pushed to 'https://myusername:mypassword@github.com/ingydotnet/git-subrepo.git' (dev).

these are with example repos and credentials.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants