Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default settings to sample config of merge aggregator #16181

Open
R290 opened this issue Nov 12, 2024 · 0 comments
Open

Add default settings to sample config of merge aggregator #16181

R290 opened this issue Nov 12, 2024 · 0 comments
Labels
feature request Requests for new plugin and for new features to existing plugins

Comments

@R290
Copy link
Contributor

R290 commented Nov 12, 2024

Use Case

My use case relies on a quick (order seconds) throughput from acquisition to writing to the database. The merge aggregator has a default window of 30 seconds and writes the metrics after this window has closed. I wanted to modify these settings and found this without any defaults listed: https://github.com/influxdata/telegraf/tree/master/config#aggregator-plugins. You actually need to look inside the code to find these:

telegraf/config/config.go

Lines 1360 to 1365 in 1cfc65a

conf := &models.AggregatorConfig{
Name: name,
Delay: time.Millisecond * 100,
Period: time.Second * 30,
Grace: time.Second * 0,
}
. The alternative is to enable the debug mode.

Expected behavior

The default values should be listed in the sample config of the merge aggregator plugin. Preferably with some description on what the Delay, Grace and Period settings actually do.

Actual behavior

The default 30 second merge window is sometimes too long and is not that straightforward to modify.

Additional info

Might apply to other aggregators as well?

@R290 R290 added the feature request Requests for new plugin and for new features to existing plugins label Nov 12, 2024
@R290 R290 changed the title Add default settins to sample config of merge aggregator Add default settings to sample config of merge aggregator Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new plugin and for new features to existing plugins
Projects
None yet
Development

No branches or pull requests

1 participant