Include contrib folder and pytorch stringifier #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
georgepar
force-pushed
the
main
branch
2 times, most recently
from
367918a
to
24012f7
Compare
This PR introduces a new contrib folder under pudb for community customization. A stringifier for pytorch is included. Detailed changelog: * A module was added under pudb/contrib/stringifiers as place to store custom stringifiers. * A stringifier for pytorch tensors and modules is included. * An option was added in the settings menu for the user to enable or disable the cotrib content for users that want to stick to the core pudb installation. * Changes were made in var_view.py and settings.py to allow for inclusion of the contrib/stringifiers in the configuration menu. Signed-off-by: Giorgos Paraskevopoulos <geopar@central.ntua.gr>
inducer
reviewed
Oct 22, 2021
| @@ -0,0 +1,46 @@ | |||
| try: | |||
There was a problem hiding this comment.
Could you have the CI install pytorch to make sure this code is tested?
| @@ -47,7 +47,7 @@ | |||
| "Topic :: Terminals", | |||
| "Topic :: Utilities", | |||
| ], | |||
| packages=["pudb"], | |||
| packages=["pudb", "pudb.contrib", "pudb.contrib.stringifiers"], | |||
There was a problem hiding this comment.
Suggested change
| packages=["pudb", "pudb.contrib", "pudb.contrib.stringifiers"], | |
| packages=find_packages(), |
Import from setuptools.
| from typing import Any | ||
|
|
||
| try: | ||
| import torch |
There was a problem hiding this comment.
This is heavyweight, and it should only happen if the stringifier is actually used, not unconditionally on every import.
| @@ -270,6 +277,14 @@ def _update_config(check_box, new_state, option_newvalue): | |||
| bool(conf_dict["hide_cmdline_win"]), on_state_change=_update_config, | |||
| user_data=("hide_cmdline_win", None)) | |||
|
|
|||
| enable_community_contributed_content = urwid.CheckBox( | |||
| "Enable community contributed content. This will give you access to more " | |||
There was a problem hiding this comment.
Suggested change
| "Enable community contributed content. This will give you access to more " | |
| "Enable community contributed content. This will give you access to more " |
| @@ -270,6 +277,14 @@ def _update_config(check_box, new_state, option_newvalue): | |||
| bool(conf_dict["hide_cmdline_win"]), on_state_change=_update_config, | |||
| user_data=("hide_cmdline_win", None)) | |||
|
|
|||
| enable_community_contributed_content = urwid.CheckBox( | |||
There was a problem hiding this comment.
All other settings in pudb act instantaneously. This one should, too.
|
Unsubscribing... @-mention or request review once it's ready for a look or needs attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new contrib folder under pudb for community
customization. A stringifier for pytorch is included.
Related issue: #475
Detailed changelog:
custom stringifiers.
disable the cotrib content for users that want to stick to the core
pudb installation.
inclusion of the contrib/stringifiers in the configuration menu.
Signed-off-by: Giorgos Paraskevopoulos geopar@central.ntua.gr