Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/33 breaking out game recap components #34

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

zachale
Copy link
Collaborator

@zachale zachale commented Oct 28, 2024

Overview

Services

  • Added a cache variable to getImages, so it will only call the API once but can be reused across the app
  • Broke _getDay into its own exported service for easy access
  • Created Score service to handle score text generation

Components

  • Created a general components directory for all components
  • Broke out ShareButton and PhotoCarousel into separate components
  • Refactored the logic that checks if a user has played today to save in local storage instead of cookies
  • Refactored score logic to be linked to a choiceKeeper ( an array of Choice )

Types

  • Added Choice Type to link images and user choices together and track user choices
  • Changed all interfaces to types out of preference

Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for vermillion-biscuit-931b88 ready!

Name Link
🔨 Latest commit 062ad38
🔍 Latest deploy log https://app.netlify.com/sites/vermillion-biscuit-931b88/deploys/673c07e273ef2d00082a92a0
😎 Deploy Preview https://deploy-preview-34--vermillion-biscuit-931b88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@zachale zachale force-pushed the feature/33-breaking-out-game-recap-components branch from 5d20eb8 to 062ad38 Compare November 19, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant