AWS deployment #34
Merged
AWS deployment #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will squash and merge once approved LOL. See comment in PR for "bandaid" |
zachale
reviewed
Sep 2, 2024
| Threshold: 100 # 100% of budget is used | ||
| Subscribers: | ||
| - SubscriptionType: EMAIL | ||
| Address: !Ref emailAddress |
There was a problem hiding this comment.
This makes me curious if rate limiting is something we can easily add, just to cover our bases
There was a problem hiding this comment.
Will be moved to later PR
nathan-probert
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
build_lambda_code.pythat builds a .zip file for deploymentawsdirectoryNOTE: The bandaid mentioned here is simply how the pipeline can be invoked - since
on: [workflow_dispatch]means the pipeline can only be manually triggered on the default branch, we needon: [..., pull_request]to test our changes on a feature branch