Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error indication for a successful program analysis #269

Open
elfring opened this issue Sep 28, 2021 · 7 comments
Open

Fix error indication for a successful program analysis #269

elfring opened this issue Sep 28, 2021 · 7 comments

Comments

@elfring
Copy link

elfring commented Sep 28, 2021

I tried the current analysis tool out once more.

[Markus_Elfring@fedora lokal]$ guider/guider.py btrace 'find /home/Markus_Elfring/Downloads -name A5-test1.odt' -c getdents64
… ver_3.9.8_210928 on python_3.9
…
0.130752 +++ exited find(8158) with 0 +++

[ERROR] terminated find(8158)

I wonder about the red information in the last line.

@iipeace
Copy link
Owner

iipeace commented Sep 29, 2021

It's just about information for user :)
in multiple task tracing cases,
It helps user can recognize one of them is terminated.

@elfring
Copy link
Author

elfring commented Sep 29, 2021

in multiple task tracing cases,

I traced only one program for my test example.

It helps user can recognize one of them is terminated.

  • How do the displays “…with 0…” and “[ERROR] …” fit together?
  • I find a single result message sufficient here.

@iipeace
Copy link
Owner

iipeace commented Sep 29, 2021

How do the displays “…with 0…” and “[ERROR] …” fit together?

"... with 0" is for trace mode,
[ERROR] is for all mode including trace, profile, ...

they has different purpose for each other.
was it uncomfortable?

@elfring
Copy link
Author

elfring commented Sep 29, 2021

I do not expect an error (or info/debug) message at the end after I got the impression that a program analysis test run succeeded.

@iipeace
Copy link
Owner

iipeace commented Sep 29, 2021

what do you think about changing [ERROR] to [WARN] or [INFO]?

@elfring
Copy link
Author

elfring commented Sep 29, 2021

An alternative category might make more sense for other messages.
At which source code places would such an adjustment be applied?

@iipeace
Copy link
Owner

iipeace commented Sep 29, 2021

You can check at 91,564 line.

                    # print status #
                    SysMgr.printErr(
                        'terminated %s(%s)' % (self.comm, self.pid))

I will change it to ERROR to WARN so that the message will not shown without verbose option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants