Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

em_mysql2 should turn on strict mode #197

Open
dgutov opened this issue May 23, 2015 · 4 comments
Open

em_mysql2 should turn on strict mode #197

dgutov opened this issue May 23, 2015 · 4 comments

Comments

@dgutov
Copy link
Collaborator

dgutov commented May 23, 2015

mysql2 does that by default since Rails 4.0: rails/rails#6069

@igrigorik
Copy link
Owner

@dgutov sounds reasonable. willing to put together a quick pull? :)

@dgutov
Copy link
Collaborator Author

dgutov commented May 25, 2015

@igrigorik I might (though it wouldn't be quick), but it seems #190 takes care of that problem as well.

@igrigorik
Copy link
Owner

Ah, fair enough. Should we close this and track it there then?

p.s. thanks for your work on AR driver!

@dgutov
Copy link
Collaborator Author

dgutov commented May 25, 2015

I'd rather we keep this open: that pull request is primarily about a different issue, and there's no guarantee that it'll be good to merge in the foreseeable future.

No problem, but I've only touched the tests. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants