Package exports mean other packages are re-exported #318
jamesedmonston
started this conversation in
General
Replies: 1 comment
-
Thank you for sharing your feedback.
This is by design to make this package highly extensible. For instance, you can build your own plugins and reference all internal types.
Yes, this naming collision is quite unfortunate, and I've been considering renaming |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Describe the bug
Thank you for this library, it's working really well for us!
The only issue I've been facing is whilst developing, I often end up incorrectly importing types from
yet-another-react-lightbox/*
. The package seems to be re-exporting a bunch of stuff.I don't think it's a project config issue, but it very well could be!
Thanks!
Expected behavior
Only export the relevant types.
How to reproduce
Copy the following into a new component file, then do
ctrl+space
for autocomplete to suggest imports. It should only show the import fromreact
(or other packages that might export that type).Screenshots / Logs
Additional context
No response
Beta Was this translation helpful? Give feedback.
All reactions