Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow for no-config adds #112

Closed
ieedan opened this issue Nov 20, 2024 · 5 comments · Fixed by #160
Closed

feat: Allow for no-config adds #112

ieedan opened this issue Nov 20, 2024 · 5 comments · Fixed by #160
Assignees
Labels
enhancement New feature or request

Comments

@ieedan
Copy link
Owner

ieedan commented Nov 20, 2024

This would allow you to add without a config file. Much nicer than erroring without a config file. Tests and diffs should still require one though.

Basically in the add command it would prompt you:

1. Would you like to add a config? Y/n (recommended)
-- yes path --
run `init`
-- no path --
wait until after blocks are selected
where would you like to add the blocks? 
src/blocks
would you like to include tests? y/N

I think this would be nice if a library wanted to just tell their users to install their components by saying:

npx jsrepo add github/ieedan/std/utilities/math
@ieedan ieedan self-assigned this Nov 20, 2024
@ieedan ieedan added the enhancement New feature or request label Nov 20, 2024
@ieedan

This comment was marked as outdated.

@ieedan

This comment has been minimized.

@ieedan ieedan closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@ieedan ieedan reopened this Nov 23, 2024
@ieedan

This comment was marked as outdated.

@ieedan

This comment was marked as off-topic.

@ieedan
Copy link
Owner Author

ieedan commented Nov 25, 2024

A little better planning for this one...

I think users not using a config should be prompted by the cli when running add along the lines of:

You don't have jsrepo initialized in your project. Do you want to continue? 
y/N

after: After the user has chosen the blocks they want to install

if: Y
Where would you like to install the blocks?
<path>

if: any of the blocks have tests
Include tests?
y/N

Add a watermark?
Y/n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant