Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Toolkit export regex matching on glb import #294

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Fix for Toolkit export regex matching on glb import #294

merged 1 commit into from
Sep 30, 2022

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Sep 30, 2022

No description provided.

@mikeskydev
Copy link
Member

Mitigates icosa-foundation/open-brush-toolkit#5

@mikeskydev mikeskydev added the bugfix Something has been fixed label Sep 30, 2022
mikeskydev
mikeskydev approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@mikeskydev mikeskydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Regex parse returns what TBT/OBT expect.

@mikeskydev mikeskydev merged commit 1cda25e into main Sep 30, 2022
@mikeage mikeage deleted the fix/glb_generator_string branch September 30, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeskydev mikeskydev mikeskydev approved these changes

@mikeage mikeage Awaiting requested review from mikeage

Assignees
No one assigned
Labels
bugfix Something has been fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybak @mikeskydev